Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate Tests for DeleteStudentsActionTest #13205

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[#12048] Migrate Tests for DeleteStudentsActionTest #13205

wants to merge 10 commits into from

Conversation

DhiraPT
Copy link

@DhiraPT DhiraPT commented Jan 27, 2025

Part of #12048

Outline of Solution
Migrated DeleteStudentsActionTest to use SQL-based logic instead of the previous Datastore model.

@github-actions GitHub Actions
Copy link

Hi @DhiraPT, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

dishenggg
dishenggg requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work thanks for the PR! Just one small change

src/test/java/teammates/sqlui/webapi/DeleteStudentsActionTest.java Outdated Show resolved Hide resolved
@dishenggg dishenggg added the s.Ongoing The PR is being worked on by the author(s) label Feb 13, 2025
dishenggg
dishenggg requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work just one small change

src/test/java/teammates/sqlui/webapi/DeleteStudentsActionTest.java Show resolved Hide resolved
@DhiraPT DhiraPT force-pushed the db-migrate-DeleteStudentsActionTest branch from e85d15a to d3d07f2 Compare February 15, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dishenggg dishenggg dishenggg requested changes

@xenosf xenosf Awaiting requested review from xenosf

Requested changes must be addressed to merge this pull request.

Assignees

@DhiraPT DhiraPT

Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DhiraPT @dishenggg